A fork of LiveLockScreen that rotates images as your lock screen background.
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
EGO-P-006 warning
unnecessary build and translation artifacts should not be shipped
Compiled GSettings schemas should not be shipped for 45+ packages.
Don't include unnecessary files
ScreenSaver
schemas/gschemas.compiled
schemas/gschemas.compiled
| Version | Status |
|---|---|
| 1.0.3 (5) | Active |
| 1.0.2 (4) | Rejected |
| 1.0.1 (3) | Active |
| 1.0.0 (2) | Rejected |
| 1.0.0 (1) | Rejected |
What's the difference between this one and the original? You should also mention it is a fork of the other extension and please fix shexli issue before any review.
I missed the first review. Please let me do a full review on this now.
1. Doesn't exist in the class (line 457-460 `extension.js`). 2. Timeout should be removed on destroy and before creating a new one: - line 294 `extension.js` - line 311 `core/mpv_player_process.js` [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 3. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 4. You need to mention in the description that this extension is a fork of the other extension: [EGO Review Guidelines: Fork](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions