Review of "Auto Accent Colour" version 21

Details Page Preview

Automatically set GNOME's accent colour based on the wallpaper.

Extension Homepage
https://codeberg.org/Wartybix/GNOME-Auto-Accent-Colour/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2

Shexli found 3 issues that may need reviewer attention.

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • color-thief/color-thief.js
  • color-thief/quantize.js
  • color-thief/run-color-thief.js

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['49', '50', '51']

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:171
            this._cacheDirMonitor = cacheDir.monitor(
                Gio.FileMonitorFlags.WATCH_MOVES,
                null
            )

All Versions

Version Status
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Rejected
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Rejected
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection active