Review of "Switch Focus Type" version 21

Details Page Preview

Toggle between focus-follow-mouse and click-to-focus mode

Extension Homepage
https://github.com/Rmano/gse-switch-focus-mode

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2

Shexli found 3 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:66
    icon_c = new St.Icon({ style_class: 'system-status-icon'})
  • extension.js:64
    icon_f = new St.Icon({ style_class: 'system-status-icon'})

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Version Status
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Rejected
12 Active
11 Active
10 Active
9 Active
8 Rejected
7 Active
6 Rejected
5 Active
4 Active
3 Active
2 Active
1 Inactive

Previous Reviews on this Version

JustPerfection active
r_mano posted a review
Thanks. Not sure if I understand the shexli error... About the warnings, I'll explore.
JustPerfection posted a review
It's okay. We approve extensions once the rc is out.
r_mano posted a review
Ok --- but still I do not understand the error: "Field `shell-version` contains invalid values, more than one development release, or implausible future releases." I have just _one_ development release (51), don't I? So the error shouldn't trigger...
JustPerfection posted a review
It's false positive.