Review of "Notification History" version 1

Details Page Preview

Adds per-application notification counts and a searchable session history to GNOME Shell.

Extension Homepage
https://github.com/vquand/gnome-extension-enhanced-notifications

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • application.js

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:453
    this._historyButton.connect('clicked', () => this._openHistory())

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

willdo auto- rejected
Auto-rejected because of new version 2 was uploaded