GNOME Shell Extensions

Review of "Notification History" version 2

Details Page Preview

Notification History

by willdo

Adds per-application notification counts and a searchable session history to GNOME Shell.

Extension Homepage
https://github.com/vquand/gnome-extension-enhanced-notifications
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:436 
            this._topIndicatorContent = new St.BoxLayout({
            style_class: 'notification-history-top-indicator-content',
        })

All Versions

Version Status
2 Unreviewed
1 Rejected