Review of "Deskflow Wallpapers" version 3

Details Page Preview

Автоматична зміна шпалер для кожного робочого простору. Individual wallpapers for each workspace.

Extension Homepage
https://github.com/Ezdrael/deskflow-wallpapers

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 13 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:89
    console.error('DeskflowWallpapers: Помилка парсингу', e)
  • extension.js:158
    console.error(`DeskflowWallpapers: Failed to download ${filename}`, e)
  • extension.js:16
    console.log('DESKFLOW LOG: enable() started')
  • extension.js:20
    console.log('DESKFLOW LOG: calling _initDefaultWallpapers')
  • extension.js:26
    console.log('DESKFLOW LOG: connecting signals')
  • extension.js:38
    console.log('DESKFLOW LOG: connecting workspaces-reordered')
  • extension.js:43
    console.log('DESKFLOW LOG: calling _onWorkspacesCountChanged')
  • extension.js:47
    console.log('DESKFLOW LOG: setting up indicator')
  • extension.js:54
    console.log('DESKFLOW LOG: connecting wallpapers-map signal')
  • extension.js:60
    console.log('DESKFLOW LOG: calling _onActiveWorkspaceChanged at end of enable')

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:9
    this._settings = this.getSettings()
  • prefs.js:16
            this._workspacesGroup = new Adw.PreferencesGroup({
                title: 'Робочі столи',
                description: 'Встановіть індивідуальні шпалери для кожного з виявлених робочих просторів.'
            })

All Versions

Version Status
7 Unreviewed
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

SOTOmax auto- rejected
Auto-rejected because of new version 4 was uploaded