Review of "Deskflow Wallpapers" version 4

Details Page Preview

Автоматична зміна шпалер для кожного робочого простору. Individual wallpapers for each workspace.

Extension Homepage
https://github.com/Ezdrael/deskflow-wallpapers

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 15 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:81
    console.error('DeskflowWallpapers overview patch error:', e)
  • extension.js:139
    console.error('DeskflowWallpapers: Помилка парсингу', e)
  • extension.js:208
    console.error(`DeskflowWallpapers: Failed to download ${filename}`, e)
  • extension.js:17
    console.log('DESKFLOW LOG: enable() started')
  • extension.js:21
    console.log('DESKFLOW LOG: calling _initDefaultWallpapers')
  • extension.js:27
    console.log('DESKFLOW LOG: connecting signals')
  • extension.js:39
    console.log('DESKFLOW LOG: connecting workspaces-reordered')
  • extension.js:44
    console.log('DESKFLOW LOG: calling _onWorkspacesCountChanged')
  • extension.js:48
    console.log('DESKFLOW LOG: patching overview')
  • extension.js:85
    console.log('DESKFLOW LOG: setting up indicator')

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:9
    this._settings = this.getSettings()
  • prefs.js:16
            this._workspacesGroup = new Adw.PreferencesGroup({
                title: 'Робочі столи',
                description: 'Встановіть індивідуальні шпалери для кожного з виявлених робочих просторів.'
            })

All Versions

Version Status
7 Unreviewed
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
This code seems to be generated by AI. Please note, we have a rule for that: - [EGO Review Guidelines: AI](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-must-not-be-ai-generated) - [Extensions Best Practices Guidelines](https://gjs.guide/extensions/review-guidelines/best-practices.html#submissions-require-maintainership)