Review of "Wallpapi" version 1.1.0 (2)

Details Page Preview

Omarchy-style wallpaper picker: browse a folder of wallpapers as a full-screen carousel of parallelogram cards and press Enter to set your background (light/dark scheme-aware).

Extension Homepage
https://github.com/SSHounaks/wallpapi

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:257
            this._bottomBar = new St.BoxLayout({
                vertical: true,
                style_class: 'wallpapi-bottom',
                x_expand: true,
            })
  • extension.js:254
    this._carouselArea = new Clutter.Actor()
  • extension.js:262
            this._currentLabel = new St.Label({
                text: '',
                style_class: 'wallpapi-current',
            })
  • extension.js:247
            this._folderLabel = new St.Label({
                text: '',
                style_class: 'wallpapi-folder',
            })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:108
            this._button.connect('button-press-event', () => {
                this._toggleOverlay();
                return Clutter.EVENT_STOP;
            })
  • extension.js:150
                    mon.connect('changed', (m, file, other, ev) => {
                        if (ev === Gio.FileMonitorEvent.CHANGED ||
                            ev === Gio.FileMonitorEvent.ATTRIBUTE_CHANGED ||
                            ev === Gio.FileMonitorEvent.PRE_UNMOUNT ||
                            ev === G

All Versions

Version Status
1.2.0 (4) Unreviewed
1.1.0 (3) Active
1.1.0 (2) Rejected
1.0.0 (1) Rejected

Previous Reviews on this Version

shalnark auto- rejected
Auto-rejected because of new version 1.1.0 (3) was uploaded