Review of "Wallpapi" version 1.3.0 (5)

Details Page Preview

A simple wallpaper picker with style: browse your folder as a full-screen carousel of parallelogram cards and press Enter to set it. Supports still images and live video wallpapers.

Extension Homepage
https://github.com/SSHounaks/wallpapi

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • renderer.js

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:120
                    this._restoreId = GLib.timeout_add(
                        GLib.PRIORITY_DEFAULT, 500, () => {
                            this._restoreId = 0;
                            this._restoreCurrentVideo(attempt + 1);
                            return GLib.SOURCE_REMOVE;
                        })

All Versions

Version Status
1.3.0 (6) Rejected
1.3.0 (5) Rejected
1.2.0 (4) Active
1.1.0 (3) Active
1.1.0 (2) Rejected
1.0.0 (1) Rejected

Previous Reviews on this Version

shalnark auto- rejected
Auto-rejected because of new version 1.3.0 (6) was uploaded