Review of "VPN Indicator" version 5

Details Page Preview

Display current VPN name in panel.

Extension Homepage
https://github.com/fthx/vpn-indicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:36
    this._clickGesture.connect('recognize', () => Util.trySpawnCommandLine('gnome-control-center network'))

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['49', '50', '51']

All Versions

Version Status
6 Active
5 Rejected
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

fthx auto- rejected
Auto-rejected because of new version 6 was uploaded