GNOME Shell Extensions

Review of "VPN Indicator" version 4

Details Page Preview

VPN Indicator

by fthx

Display current VPN name in panel.

Extension Homepage
https://github.com/fthx/vpn-indicator
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:36 
    this._clickGesture.connect('recognize', () => Util.trySpawnCommandLine('gnome-control-center network'))

All Versions

Version Status
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

fthx posted a review
Hi, Probably a false positive warning. No changes here: 1 typo for disconnectObject and code syntax cleanup.
fmuellner active