Review of "Bottom Dash Panel" version 24

Details Page Preview

Turn the native GNOME dash into a bottom panel. Settings: dock mode, hide top panel, display on all monitors, panel height, panel background color... Very short code, very light extension: the dash object is the GNOME dash object itself.

Extension Homepage
https://github.com/fthx/bottom-dash-panel

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2

Shexli found 3 issues that may need reviewer attention.

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:158
    this._bottomEdge = new BottomEdge(this._settings, this._monitor)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:146
    this.showAppsButton.connect('notify::checked', () => this._onShowAppsButtonClicked())

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['46', '47', '48', '49', '50', '51']

All Versions

Version Status
24 Active
23 Active
22 Active
21 Active
20 Rejected
19 Active
18 Rejected
17 Rejected
16 Rejected
15 Rejected
14 Active
13 Active
12 Active
11 Rejected
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Rejected
1 Active

Previous Reviews on this Version

JustPerfection active