Review of "Switch Workspace" version 46

Details Page Preview

Switch workspace like using ALT+TAB key to switch windows Default shortcut key to switch workspace is Ctrl+Above_Tab .

Extension Homepage
https://github.com/sunwxg/gnome-shell-extension-switchworkspace

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 2 warning 3

Shexli found 5 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.switchworkspace.gschema.xml
    id='org.gnome.shell.extensions.switchWorkSpace' path='/org/gnome/shell/extensions/switchWorkSpace/'

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:329
    bbox
  • extension.js:264
    icon

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['51']

EGO-C45-001 warning

45+ preferences should use fillPreferencesWindow instead of getPreferencesWidget

45+ preferences code should use `fillPreferencesWindow()` instead of `getPreferencesWidget()`.

Preferences

  • prefs.js:149
        getPreferencesWidget() {
            return buildPrefsWidget(this.getSettings(), this.dir);
        }

All Versions

Previous Reviews on this Version

JustPerfection active
JustPerfection posted a review
Please fix those warnings mentioned by shexli.