Review of "Gradient Top Bar" version 25

Details Page Preview

Give GNOME's top bar a customizable gradient - choose direction and colors, and optionally use a different style or keep the theme when windows are maximized.

Extension Homepage
https://github.com/petar-v/gradienttopbar

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 3

Shexli found 4 issues that may need reviewer attention.

EGO-X-002 warning

extensions should not use synchronous subprocess APIs in shell code

Shell code should avoid synchronous subprocess APIs like `GLib.spawn_command_line_sync()` and `GLib.spawn_sync()`.

Complete Examples

  • config.js:183
    GLib.spawn_command_line_sync(
            `dconf dump ${SETTINGS_GSCHEMA_PATH}`
        )

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-001 warning

extension must not create GObject instances or modify shell before enable()

Resource creation or signal/source setup was found outside `enable()`.

Only use initialization for static resources

  • extension.js:72
            this.windowEvents = new WindowEvents(
                global.display,
                global.window_manager,
                global.get_workspace_manager()
            )

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['49', '50', '51']

All Versions

Previous Reviews on this Version

JustPerfection active