EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

• src/Shader.js
• src/ShaderFactory.js

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

• extension.js:121

  this._shellSettings = new Gio.Settings({schema: 'org.gnome.desktop.interface'})

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• extension.js:116

      this._settings.connect('changed::active-profile', () => {
        this._loadProfiles();
      })

• extension.js:390

  p.settings.connect('changed::profile-animation-type', () => updatePriority(p))

• extension.js:389

  p.settings.connect('changed::profile-app', () => updatePriority(p))

• extension.js:392

  p.settings.connect('changed::profile-color-scheme', () => updatePriority(p))

• extension.js:395

  p.settings.connect('changed::profile-high-priority', () => updatePriority(p))

• extension.js:393

  p.settings.connect('changed::profile-power-mode', () => updatePriority(p))

• extension.js:394

  p.settings.connect('changed::profile-power-profile', () => updatePriority(p))

• extension.js:391

  p.settings.connect('changed::profile-window-type', () => updatePriority(p))

• extension.js:255

        container.connect('destroy', () => {
          delete realWindow._bmwOverviewClone;
          delete realWindow._bmwOverviewCloneContainer;
        })

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

• prefs.js:91

      this._resources =
        Gio.Resource.load(this.path + '/resources/burn-my-windows.gresource')

• prefs.js:99

  this._builder = new Gtk.Builder()

• prefs.js:105

  this._settings = this.getSettings()

• prefs.js:108

  this._profileManager = new ProfileManager(this.metadata)

• prefs.js:148

      this._dbusConnection = Gio.DBus.session.signal_subscribe(
        'org.gnome.Shell', 'org.gnome.shell.extensions.BurnMyWindows', 'WindowPicked',
        '/org/gnome/shell/extensions/BurnMyWindows', null, Gio.DBusSignalFlags.NONE,
        (conn, sender, obj_path, iface, signal, params) => {
          con

• prefs.js:175

  this._widget = this._builder.get_object('general-prefs')

• prefs.js:191

  this._searchEntry = this._builder.get_object('search_entry')

• prefs.js:329

          this._showUpdateInfoTimeout =
            GLib.timeout_add(GLib.PRIORITY_DEFAULT, 2000, () => {
              this._showUpdateInfoTimeout = 0;
  
              const toast = Adw.Toast.new(_('Burn-My-Windows has been updated!'));
              toast.set_button_label(_('View Changelog'));
              to

• prefs.js:662

  this._activeProfile = allProfiles.find(p => p.path == path)