Review of "Mond Clock Desktop Widget" version 1

Details Page Preview

Widget de data e hora minimalista idêntico à skin Mond do Rainmeter, com fontes Anurati e Quicksand, drag-and-drop e zoom via scroll.

Extension Homepage
https://github.com/jaovinic/mond-clock-extension

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:36
            this._labelDate = new St.Label({
                style_class: 'mond-date',
                x_align: Clutter.ActorAlign.CENTER,
                x_expand: true,
            })
  • extension.js:27
            this._labelDay = new St.Label({
                style_class: 'mond-day',
                x_align: Clutter.ActorAlign.CENTER,
                x_expand: true,
            })
  • extension.js:45
            this._labelTime = new St.Label({
                style_class: 'mond-time',
                x_align: Clutter.ActorAlign.CENTER,
                x_expand: true,
            })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:234
            this._container.connect('button-press-event', (actor, event) => {
                const button = event.get_button();
                if (button !== 1)
                    return Clutter.EVENT_PROPAGATE;
    
                const clickTime = event.get_time();
    
                // Duplo clique com botão esquerdo abre
  • extension.js:287
            this._container.connect('button-release-event', (actor, event) => {
                if (this._isDragging && event.get_button() === 1) {
                    const [finalX, finalY] = actor.get_position();
                    this._cleanupDrag(actor);
                    this._settings.set_double('pos-x', fina
  • extension.js:275
            this._container.connect('motion-event', (actor, event) => {
                if (this._isDragging) {
                    const [stageX, stageY] = event.get_coords();
                    const deltaX = stageX - dragStartX;
                    const deltaY = stageY - dragStartY;
                    actor.set_posit
  • extension.js:299
            this._container.connect('scroll-event', (actor, event) => {
                const direction = event.get_scroll_direction();
                let currentScale = this._settings.get_double('scale');
                const step = 0.05;
    
                if (direction === Clutter.ScrollDirection.UP) {
                 

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Rejected

Previous Reviews on this Version

João Vinícius posted a review
João Vinícius auto- rejected
Auto-rejected because of new version 2 was uploaded