Review of "Mond Clock Desktop Widget" version 3

Details Page Preview

Widget de data e hora minimalista idĂȘntico Ă  skin Mond do Rainmeter, com fontes Anurati e Quicksand, drag-and-drop e zoom via scroll.

Extension Homepage
https://github.com/jaovinic/mond-clock-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:36
        this._labelDate = new St.Label({
          style_class: "mond-date",
          x_align: Clutter.ActorAlign.CENTER,
          x_expand: true,
        })
  • extension.js:27
        this._labelDay = new St.Label({
          style_class: "mond-day",
          x_align: Clutter.ActorAlign.CENTER,
          x_expand: true,
        })
  • extension.js:45
        this._labelTime = new St.Label({
          style_class: "mond-time",
          x_align: Clutter.ActorAlign.CENTER,
          x_expand: true,
        })

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Rejected