Review of "Tiling Assistant Rounded" version 6

Details Page Preview

Expand GNOME's 2 column tiling with rounded corners to all windows and add a Windows-snap-assist-inspired popup.

Extension Homepage
https://github.com/nilocnt/tiling-assistant-rounded

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 3

Shexli found 4 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • rounded/effect/linear_filter_effect.js

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • src/dependencies/unexported/altTab-48.js:606
    arrow
  • src/dependencies/unexported/altTab-48.js:656
    name
  • src/dependencies/unexported/altTab-48.js:648
    bin

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['48', '49', '50', '51']

All Versions

Version Status
8 Unreviewed
7 Rejected
6 Unreviewed
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected