Review of "Froonty" version 0.2.1 rc1 (1)

Details Page Preview

A compact Dynamic-Island-style entry point at the top center of the screen that reuses GNOME Shell's own clock, calendar and notification facilities.

Extension Homepage
https://github.com/nyculescu/froonty-gnome

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-X-003 warning

extensions should not call run_dispose in extension code

Extension code should not call `run_dispose()`.

GObject.Object.run_dispose

  • services/clock.js:75
    this._wallClock.run_dispose()

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • features/claude/view.js:301
    this.actor = new St.DrawingArea({style_class: 'froonty-claude-bar', x_expand: true})
  • features/claude/view.js:330
    this.actor = new St.DrawingArea({style_class: 'froonty-claude-chart', x_expand: true})

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • features/claude/view.js:301
    this.actor = new St.DrawingArea({style_class: 'froonty-claude-bar', x_expand: true})
  • features/claude/view.js:330
    this.actor = new St.DrawingArea({style_class: 'froonty-claude-chart', x_expand: true})

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • features/claude/view.js:302
    this.actor.connect('repaint', () => this._repaint())
  • features/claude/view.js:331
    this.actor.connect('repaint', () => this._repaint())

All Versions

Version Status
0.3.0 rc1 (2) Unreviewed
0.2.1 rc1 (1) Rejected

Previous Reviews on this Version

nyculescu auto- rejected
Auto-rejected because of new version 0.3.0 rc1 (2) was uploaded