Review of "Arch Linux Updates Indicator" version 68

Details Page Preview

Update indicator for Arch Linux and GNOME Shell. Runs gnome-terminal by default, you can change in settings. ** Note : you need to install the package pacman-contrib to use the checkupdates script. ** Can support AUR or other distros by changing command used to check for and apply updates.

Extension Homepage
https://codeberg.org/RaphaelRochet/arch-update

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 3

Shexli found 4 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:143
    this.checkNowMenuContainer = new PopupMenu.PopupMenuSection()
  • extension.js:142
    this.checkNowMenuItem = new PopupMenu.PopupMenuItem( _('Check now') )
  • extension.js:130
    this.checkingMenuItem = new PopupMenu.PopupBaseMenuItem( {reactive:false} )
  • extension.js:127
    this.managerMenuItem = new PopupMenu.PopupMenuItem(_('Open package manager'))
  • extension.js:120
    this.menuExpander = new PopupMenu.PopupSubMenuMenuItem('')
  • extension.js:121
    this.menuExpanderContainer = new St.BoxLayout({ orientation: 1, style_class: 'arch-updates-updates-list' })
  • extension.js:147
    this.timeCheckedMenu = new PopupMenu.PopupMenuItem( "-", {reactive:false} )
  • extension.js:126
    this.updateNowMenuItem = new PopupMenu.PopupMenuItem(_('Update now'))

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:177
    this._settings = this._extension.getSettings()
  • extension.js:143
    this.checkNowMenuContainer = new PopupMenu.PopupMenuSection()
  • extension.js:142
    this.checkNowMenuItem = new PopupMenu.PopupMenuItem( _('Check now') )
  • extension.js:130
    this.checkingMenuItem = new PopupMenu.PopupBaseMenuItem( {reactive:false} )
  • extension.js:127
    this.managerMenuItem = new PopupMenu.PopupMenuItem(_('Open package manager'))
  • extension.js:120
    this.menuExpander = new PopupMenu.PopupSubMenuMenuItem('')
  • extension.js:121
    this.menuExpanderContainer = new St.BoxLayout({ orientation: 1, style_class: 'arch-updates-updates-list' })
  • extension.js:147
    this.timeCheckedMenu = new PopupMenu.PopupMenuItem( "-", {reactive:false} )
  • extension.js:126
    this.updateNowMenuItem = new PopupMenu.PopupMenuItem(_('Update now'))

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:642
    this._notifSource.connect('destroy', ()=>{this._notifSource = null;})
  • extension.js:653
    this._notification.connect('destroy', ()=>{this._notification = null;})
  • extension.js:178
    this._settings.connect('changed', this._positionChanged.bind(this))
  • extension.js:161
    this.menu.connect('open-state-changed', this._onMenuOpened.bind(this))
  • extension.js:356
    this.monitor.connect('changed', this._onFolderChanged.bind(this))

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['51']

All Versions

Previous Reviews on this Version

JustPerfection active