Review of "UTCClock" version 41

Details Page Preview

UTC clock for the top bar

Extension Homepage
https://github.com/injcristianrojas/UTCClock

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 3

Shexli found 4 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:146
                this.ClockMenu12Hour = new PopupMenu.PopupSwitchMenuItem(
                    '12-hour mode',
                    this.settings.get_boolean('twelvehour-enabled'),
                    { reactive: true }
                )
  • extension.js:136
                this.ClockMenuItemDate = new PopupMenu.PopupSwitchMenuItem(
                    'Show date',
                    this.settings.get_boolean('show-date'),
                    { reactive: true }
                )
  • extension.js:157
                this.ClockMenuItemOpacity = new PopupMenu.PopupSwitchMenuItem(
                    'Light opacity',
                    this.settings.get_boolean('light-opacity'),
                    { reactive: true }
                )
  • extension.js:106
                this.ClockMenuItemSeconds = new PopupMenu.PopupSwitchMenuItem(
                    'Show seconds',
                    this.settings.get_boolean('show-seconds'),
                    { reactive: true }
                )
  • extension.js:116
                this.ClockMenuItemText = new PopupMenu.PopupSubMenuMenuItem(
                    'Time text to show'
                )
  • extension.js:124
    this.PopupMenuItemGMT = new PopupMenu.PopupMenuItem('GMT')
  • extension.js:119
    this.PopupMenuItemUTC = new PopupMenu.PopupMenuItem('UTC')
  • extension.js:129
    this.PopupMenuItemZ = new PopupMenu.PopupMenuItem('Z')

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:146
                this.ClockMenu12Hour = new PopupMenu.PopupSwitchMenuItem(
                    '12-hour mode',
                    this.settings.get_boolean('twelvehour-enabled'),
                    { reactive: true }
                )
  • extension.js:136
                this.ClockMenuItemDate = new PopupMenu.PopupSwitchMenuItem(
                    'Show date',
                    this.settings.get_boolean('show-date'),
                    { reactive: true }
                )
  • extension.js:157
                this.ClockMenuItemOpacity = new PopupMenu.PopupSwitchMenuItem(
                    'Light opacity',
                    this.settings.get_boolean('light-opacity'),
                    { reactive: true }
                )
  • extension.js:106
                this.ClockMenuItemSeconds = new PopupMenu.PopupSwitchMenuItem(
                    'Show seconds',
                    this.settings.get_boolean('show-seconds'),
                    { reactive: true }
                )
  • extension.js:116
                this.ClockMenuItemText = new PopupMenu.PopupSubMenuMenuItem(
                    'Time text to show'
                )
  • extension.js:124
    this.PopupMenuItemGMT = new PopupMenu.PopupMenuItem('GMT')
  • extension.js:119
    this.PopupMenuItemUTC = new PopupMenu.PopupMenuItem('UTC')
  • extension.js:129
    this.PopupMenuItemZ = new PopupMenu.PopupMenuItem('Z')

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Previous Reviews on this Version

JustPerfection active