Review of "GitHub Tray" version 17

Details Page Preview

Display your GitHub repositories, notifications, and Actions workflows in the system tray with real-time status updates and inline management.

Extension Homepage
https://github.com/debba/github-tray-gnome-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 4

Shexli found 5 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 38 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • ui.js:205
        console.log(
          `[GitHubTray UI] updateMenu called - repos: ${repos.length}, notifications: ${notifications.length}`,
        )
  • ui.js:410
          console.log(
            `[GitHubTray UI] Section visibility - Notifications: ${showNotifications} (setting: ${this._settings.get_boolean("show-notifications")}, count: ${unreadNotifications.length})`,
          )
  • ui.js:413
          console.log(
            `[GitHubTray UI] Section visibility - Repos: ${showRepos} (count: ${repos.length})`,
          )
  • ui.js:420
    console.log(`[GitHubTray UI] Total sections to show: ${sectionsCount}`)
  • ui.js:424
            console.log(
              "[GitHubTray UI] Using accordion layout (multiple sections)",
            )
  • ui.js:428
    console.log("[GitHubTray UI] Building notifications accordion")
  • ui.js:432
    console.log("[GitHubTray UI] Building repos accordion")
  • ui.js:437
    console.log("[GitHubTray UI] Using direct layout (single section)")
  • ui.js:439
    console.log("[GitHubTray UI] Building notifications section")
  • ui.js:2131
        console.log(
          `[GitHubTray UI] showWorkflowRunsView called for ${repo.name} with ${workflowRuns ? workflowRuns.length : 0} workflow runs`,
        )

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 7 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • workflowManager.js:35
    console.log(`[GitHubTray] No token available for fetching workflow runs`)
  • workflowManager.js:44
          console.log(
            `[GitHubTray] Fetching workflow runs for ${owner}/${repoName} (max: ${maxRuns})`,
          )
  • workflowManager.js:54
          console.log(
            `[GitHubTray] Fetched ${workflowRuns ? workflowRuns.length : 0} workflow runs for ${repo.full_name}`,
          )
  • workflowManager.js:76
        console.log(
          `[GitHubTray] Loading workflow runs for ${monitoredRepos.length} monitored repos`,
        )
  • workflowManager.js:60
          console.error(
            `[GitHubTray] Error fetching workflow runs for ${repo.full_name}:`,
            error,
          )
  • workflowManager.js:102
            console.error(
              `[GitHubTray] Error loading workflow runs for ${repo.full_name}:`,
              error,
            )
  • workflowManager.js:137
    console.error(error, "GitHubTray:rerunWorkflow")

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:55
        this._icon = new St.Icon({
          gicon: gicon,
          style_class: "system-status-icon",
        })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:55
        this._icon = new St.Icon({
          gicon: gicon,
          style_class: "system-status-icon",
        })

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Version Status
18 Rejected
17 Rejected
16 Rejected
15 Active
14 Active
13 Active
12 Rejected
11 Rejected
10 Active
9 Active
8 Rejected
7 Active
6 Rejected
5 Active
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

debba auto- rejected
Auto-rejected because of new version 18 was uploaded