Review of "GitHub Tray" version 14

Details Page Preview

Display your GitHub repositories, notifications, and Actions workflows in the system tray with real-time status updates and inline management.

Extension Homepage
https://github.com/debba/github-tray-gnome-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 5

Shexli found 5 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 33 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • ui.js:247
    console.error(e, "GitHubTray:open-profile")
  • ui.js:431
    console.error(e, "GitHubTray:updateMenu")
  • ui.js:465
    console.error(e, "GitHubTray:open-notifications")
  • ui.js:627
    console.error(e, "GitHubTray:open-notifications")
  • ui.js:907
    console.error(e, "GitHubTray:open-workflow")
  • ui.js:999
    console.error(e, "GitHubTray:open-workflow-activate")
  • ui.js:1091
    console.error(e, "GitHubTray:open-repositories")
  • ui.js:1314
    console.error(e, "GitHubTray:open-notification")
  • ui.js:1373
    console.error(e, "GitHubTray:open-repo")
  • ui.js:1418
    console.error(e, "GitHubTray:open-fork")

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 7 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • workflowManager.js:60
          console.error(
            `[GitHubTray] Error fetching workflow runs for ${repo.full_name}:`,
            error,
          )
  • workflowManager.js:102
            console.error(
              `[GitHubTray] Error loading workflow runs for ${repo.full_name}:`,
              error,
            )
  • workflowManager.js:137
    console.error(error, "GitHubTray:rerunWorkflow")
  • workflowManager.js:35
    console.log(`[GitHubTray] No token available for fetching workflow runs`)
  • workflowManager.js:44
          console.log(
            `[GitHubTray] Fetching workflow runs for ${owner}/${repoName} (max: ${maxRuns})`,
          )
  • workflowManager.js:54
          console.log(
            `[GitHubTray] Fetched ${workflowRuns ? workflowRuns.length : 0} workflow runs for ${repo.full_name}`,
          )
  • workflowManager.js:76
        console.log(
          `[GitHubTray] Loading workflow runs for ${monitoredRepos.length} monitored repos`,
        )

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:55
        this._icon = new St.Icon({
          gicon: gicon,
          style_class: "system-status-icon",
        })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:55
        this._icon = new St.Icon({
          gicon: gicon,
          style_class: "system-status-icon",
        })

All Versions

Version Status
15 Active
14 Active
13 Active
12 Rejected
11 Rejected
10 Active
9 Active
8 Rejected
7 Active
6 Rejected
5 Active
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

fmuellner active