Review of "Notification Configurator" version 24

Details Page Preview

An Ultimate Notification Configurator for GNOME: notification rate limiting, timeout, positioning, fullscreen notifications, custom colors, filtering and more features upcoming. Consider leaving a review on GNOME Extensions!

Extension Homepage
https://github.com/ExposedCat/gnome-notification-configurator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1

Shexli found 1 issue that may need reviewer attention.

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['46', '47', '48', '49', '50', '51']

All Versions

Version Status
28 Active
27 Active
26 Rejected
25 Active
24 Rejected
23 Active
22 Active
21 Rejected
20 Active
19 Rejected
18 Rejected
17 Rejected
16 Rejected
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Selective disable/destroy isn't allowed: - line 152-153 `shell/banner-lifecycle.js` - line 453-460 `shell/notification-stack.js` 2. `this.disposed` is what AI does. Please remove those: [Extension Best Practices Guidelines: Lifecycle](https://gjs.guide/extensions/review-guidelines/best-practices.html#lifecycle-and-destruction-state)