An Ultimate Notification Configurator for GNOME: notification rate limiting, timeout, positioning, fullscreen notifications, custom colors, filtering and more features upcoming. Consider leaving a review on GNOME Extensions!
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
EGO-L-005 warning
owned object references should be released in disable()
Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.
Notification Configurator
shell/media-player.js:132
this.surface = new St.Widget({
layout_manager: layout,
clip_to_allocation: true,
})
| Version | Status |
|---|---|
| 28 | Active |
| 27 | Active |
| 26 | Rejected |
| 25 | Active |
| 24 | Rejected |
| 23 | Active |
| 22 | Active |
| 21 | Rejected |
| 20 | Active |
| 19 | Rejected |
| 18 | Rejected |
| 17 | Rejected |
| 16 | Rejected |
| 15 | Active |
| 14 | Active |
| 13 | Active |
| 12 | Active |
| 11 | Active |
| 10 | Active |
| 9 | Active |
| 8 | Active |
| 7 | Active |
| 6 | Rejected |
| 5 | Rejected |
| 4 | Rejected |
| 3 | Rejected |
| 2 | Rejected |
| 1 | Rejected |
1. Avoid doing unnecessary things (line 55 `shell/notification-sound.js`). 2. `this._destroyed` is a bad practice. Please remove that: [Extensions Best Practices Guidelines: Lifecycle and Destruction State](https://gjs.guide/extensions/review-guidelines/best-practices.html#lifecycle-and-destruction-state) 3. Remove version from the import (line 4 `shell/media-player.js`). 4. Selective disable isn't allowed (line 277-278 `shell/media-player.js`). Please avoid sending large diff. It can wait even for months since the review queue is very busy.
@JustPerfection noted