Review of "Huawei WMI controls" version 20

Details Page Preview

Control various Huawei and Honor laptops WMI functions, such as battery protection, Fn-lock, power unlock and keyboard backlight.

Extension Homepage
https://apps.sdore.me/gnome-extension-huawei-wmi

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:145
    file.load_contents(null)
  • extension.js:236
    file.load_contents(null)
  • extension.js:368
    file.load_contents(null)
  • extension.js:386
    file.load_contents(null)
  • extension.js:259
    _file_sys.load_contents(null)
  • extension.js:323
    _file_sys.load_contents(null)
  • extension.js:298
    _file_def.load_contents(null)
  • extension.js:324
    _file_def.load_contents(null)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:282
    this._battery_watching = proxy.connect('g-properties-changed', this._update_top_off.bind(this))
  • extension.js:86
    		this.menu.connect('open-state-changed', () => {
    			if (this._bpm.sensitive) this._bpm.activate();
    		})

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Version Status
20 Active
19 Active
18 Rejected
17 Active
16 Active
15 Active
14 Rejected
13 Active
12 Rejected
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection active