Review of "Custom Command Toggle" version 15

Details Page Preview

[GNOME 45-51] Create fully customizable quick toggle buttons to run user defined commands and launch custom scripts.

Extension Homepage
https://github.com/StorageB/custom-command-toggle

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2

Shexli found 3 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 7 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • backup.js:108
    console.log(`[Custom Command Toggle] Toggle button settings exported to ${filePath}`)
  • backup.js:139
    console.log(`[Custom Command Toggle] Failed to export settings\n${e}`)
  • backup.js:184
    console.log(`[Custom Command Toggle] Failed to import settings. File not found.`)
  • backup.js:191
    console.log('[Custom Command Toggle] Failed to import configuration\n%s'.format(e))
  • backup.js:285
    console.log('[Custom Command Toggle] Configuration imported from %s'.format(filePath))
  • backup.js:312
    console.log('[Custom Command Toggle] All settings successfully reset to defaults')
  • backup.js:314
    console.log('[Custom Command Toggle] Failed to reset settings:', e)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:150
            this.toggle1ConnectSignal = this.toggle1.connect('clicked', () => {
                if (settings.get_boolean('closemenu1-setting')) {Main.panel.closeQuickSettings();}
                if (settings.get_int('buttonclick1-setting') === 2 && settings.get_boolean('checkexitcode1-setting')) {
                 
  • extension.js:206
            this.toggle2ConnectSignal = this.toggle2.connect('clicked', () => {
                if (settings.get_boolean('closemenu2-setting')) {Main.panel.closeQuickSettings();}
                if (settings.get_int('buttonclick2-setting') === 2 && settings.get_boolean('checkexitcode2-setting')) {
                 
  • extension.js:262
            this.toggle3ConnectSignal = this.toggle3.connect('clicked', () => {
                if (settings.get_boolean('closemenu3-setting')) {Main.panel.closeQuickSettings();}
                if (settings.get_int('buttonclick3-setting') === 2 && settings.get_boolean('checkexitcode3-setting')) {
                 
  • extension.js:318
            this.toggle4ConnectSignal = this.toggle4.connect('clicked', () => {
                if (settings.get_boolean('closemenu4-setting')) {Main.panel.closeQuickSettings();}
                if (settings.get_int('buttonclick4-setting') === 2 && settings.get_boolean('checkexitcode4-setting')) {
                 
  • extension.js:374
            this.toggle5ConnectSignal = this.toggle5.connect('clicked', () => {
                if (settings.get_boolean('closemenu5-setting')) {Main.panel.closeQuickSettings();}
                if (settings.get_int('buttonclick5-setting') === 2 && settings.get_boolean('checkexitcode5-setting')) {
                 
  • extension.js:430
            this.toggle6ConnectSignal = this.toggle6.connect('clicked', () => {
                if (settings.get_boolean('closemenu6-setting')) {Main.panel.closeQuickSettings();}
                if (settings.get_int('buttonclick6-setting') === 2 && settings.get_boolean('checkexitcode6-setting')) {
                 

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Previous Reviews on this Version

JustPerfection active