Review of "IdeaPad" version 23

Details Page Preview

Lenovo IdeaPad goodies for Gnome Shell At the moment the extension only provides an easy and user-friendly way to toggle battery conservation mode available on Levono Ideapad laptops and visually get its current state. Configuration needed! Please check the instruction on the homepage.

Extension Homepage
https://github.com/laurento/gnome-shell-extension-ideapad

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:71
    this._monitor.connect('changed', this._syncStatus.bind(this))
  • extension.js:64
                this._toggle.connect('clicked', item => {
                    this._setConservationMode(item.get_checked());
                })

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Version Status
23 Active
22 Active
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Inactive
8 Active
7 Active
6 Active
5 Rejected
4 Active
3 Inactive
2 Active
1 Active

Previous Reviews on this Version

GdH active