Review of "No Time For Caution" version 14

Details Page Preview

Display a Countdown from a specific date in top panel of gnome. Set a goal in settings and it would remind you how much time is left for that goal. You can customize the unit of time like days hours weeks or months.

Extension Homepage
https://github.com/ans-ibrahim/no-time-for-caution

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:113
        this.settings.connect("changed", () => {
          if (this._indicator) {
            this._indicator.destroy();
            this._indicator = null;
          }
          this._indicator = new Indicator(this.settings, this);
          Main.panel.addToStatusArea(
            "no-time-for-caution@ans-ibrahim.github",
           

All Versions

Version Status
16 Active
15 Active
14 Rejected
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Inactive
4 Inactive
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

GdH rejected
Please remove gschemas.compiled from the package.