Review of "Syncbeacon" version 1.2.0 (1)

Details Page Preview

Syncthing status in the top bar: a state icon with peer and folder counts, an info box with every device and folder, pause and resume, and quick access to the Syncthing web UI.

Extension Homepage
https://github.com/whoozy82/syncbeacon

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • lib/locale.js:13
    GLib.file_get_contents(path)

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:256
            this._pollId = GLib.timeout_add_seconds(GLib.PRIORITY_DEFAULT, seconds, () => {
                this._client.poll().catch(e => {
                    if (!isCancelled(e))
                        console.debug(`Syncbeacon: status poll failed: ${e}`);
                });
                return GLib.SOURCE_CONTINUE
  • extension.js:300
                this._retryId = GLib.timeout_add_seconds(GLib.PRIORITY_DEFAULT, CONFIG_RETRY_S, () => {
                    this._retryId = 0;
                    this._reconfigure();
                    return GLib.SOURCE_REMOVE;
                })
  • extension.js:380
            this._updateId = GLib.timeout_add(GLib.PRIORITY_DEFAULT, UPDATE_DELAY_MS, () => {
                this._updateId = 0;
                this._update();
                return GLib.SOURCE_REMOVE;
            })

All Versions

Version Status
1.4.1 (3) Unreviewed
1.2.4 (2) Rejected
1.2.0 (1) Rejected

Previous Reviews on this Version

whoozy auto- rejected
Auto-rejected because of new version 1.2.4 (2) was uploaded