Review of "My Next Meeting" version 1

Details Page Preview

Display the next upcoming event in your topbar, and click to join

Extension Homepage
https://github.com/macowie/gnome-shell-my-next-meeting

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:361
    St.Clipboard.get_default()

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:164
            this.menu.connect('open-state-changed', (_m, open) => {
                if (open)
                    this._fetch(true);
            })

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

mcowie auto- rejected
Auto-rejected because of new version 2 was uploaded