GNOME Shell Extensions

Review of "My Next Meeting" version 2

Details Page Preview

My Next Meeting

by mcowie

Display the next upcoming event in your topbar, and click to join

Extension Homepage
https://github.com/macowie/gnome-shell-my-next-meeting
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:165 
            this._menuHandlerId = this.menu.connect('open-state-changed', (_m, open) => {
            if (open)
                this._fetch(true);
        })

All Versions

Version Status
2 Unreviewed
1 Rejected