Review of "Junk Notification Cleaner" version 14

Details Page Preview

Delete notifications for an application when its window is focused or closed.

Extension Homepage
https://github.com/murar8/junk-notification-cleaner

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-C45-001 warning

45+ preferences should use fillPreferencesWindow instead of getPreferencesWidget

45+ preferences code should use `fillPreferencesWindow()` instead of `getPreferencesWidget()`.

Preferences

  • prefs.js:26
        getPreferencesWidget() {
            this.settings = this.getSettings();
            const page = new Adw.PreferencesPage({
                title: "Settings",
                icon_name: "preferences-system-symbolic",
            });
            page.add(this.buildGeneralGroup());
            page.add(this.buildLoggingGroup

All Versions

Version Status
16 Active
15 Rejected
14 Rejected
13 Active
12 Active
11 Active
10 Active
9 Inactive
8 Inactive
7 Inactive
6 Active
5 Active
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

murar8 posted a review
Hi, please disregard this version, I have pushed a new version that fixes the Shexli warning.
murar8 posted a review
Hi, please disregard this version, I have pushed a new version that fixes the Shexli warning.
murar8 auto- rejected
Auto-rejected because of new version 15 was uploaded