Review of "Lofi Bar" version 1.1 (3)

Details Page Preview

Lofi radio in your top bar. Curated stations play their highest-quality stream (FLAC lossless or 320 kbps), with automatic fallback to the next-best format. More lofi stations come from the Radio Browser directory, each on its best available stream. Scroll on the icon to change the volume. Music keeps playing while the screen is locked.

Extension Homepage
https://github.com/obk/lofi-bar

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • player.js:121
    this._bus.connect('message', (_bus, msg) => this._onMessage(msg))
  • player.js:110
            this._pipeline.connect('source-setup', (_pb, source) => {
                if ('user_agent' in source)
                    source.user_agent = USER_AGENT;
                if ('timeout' in source)
                    source.timeout = 15;
                if ('iradio_mode' in source)
                    source.iradio_m

All Versions

Version Status
1.2 (4) Unreviewed
1.1 (3) Rejected
1.0 (2) Rejected
1.0 (1) Rejected

Previous Reviews on this Version

Ghost auto- rejected
Auto-rejected because of new version 1.2 (4) was uploaded