Review of "Plaid" version 2

Details Page Preview

Plaid brings tiling to GNOME Shell: dwindle, master-stack and centered master-stack layouts, a floating layout, configurable gaps, animated gradient borders, rounded corners, window blur, remappable keybindings, float rules, a scratchpad, drop-down terminal, and mouse resize/swap.

Extension Homepage
https://github.com/Plyply99/Plaid

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
v51.26 (4) Unreviewed
v51.25 (3) Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Plyply posted a review
# Plaid v2 — review update (version 5124) ## Shexli warnings fixed - **EGO-X-004** — replaced synchronous `/proc` reads with cached async reads for float rules, Chromium/Steam hover exclusion, the Extensions app, and the BGAPP/DDT process markers. No blocking file IO remains in shell code. - **EGO-X-006** — removed `Extension.lookupByUUID()`. - **EGO-L-004** — GLib idle/timeout sources are tracked and removed in `disable()`; async marker waiters are rechecked when identity resolves. ## Best-practices pass - Removed `this._destroyed`; `disable()` is exception-safe and the tracked source registry guarantees cleanup. - Removed redundant empty catches around standard lifecycle/repaint calls. The remaining empty catches guard Meta/Clutter window and actor calls that can run against a disposed object during teardown. - Split the entry point into modules: `extension.js` is now ~2,180 lines across 22 modules. `enable()` and `disable()` are adjacent. - Removed the optional terminal-settings/profile-integration feature and its shell/fish scripts (this also removes the outside-extension shell-profile writes). - The drop-down terminal claim uses async process markers.
JustPerfection rejected
Didn't review. Please follow the best practice guidelines. Especially this one: https://gjs.guide/extensions/review-guidelines/best-practices.html#keep-the-default-entry-point-as-small-as-possible and avoid unnecessary functions like `_disable()` and try-catch like in enable function.