Review of "Plaid" version v51.26 (4)

Details Page Preview

Plaid brings tiling to GNOME Shell: dwindle, master-stack and centered master-stack layouts, a floating layout, configurable gaps, animated gradient borders, rounded corners, window blur, remappable keybindings, float rules, a scratchpad, drop-down terminal, and mouse resize/swap.

Extension Homepage
https://github.com/Plyply99/Plaid

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
v51.26 (4) Unreviewed
v51.25 (3) Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Plyply posted a review
All ten points from the v51.25 review are addressed: 1. Removed try/catch around calls that cannot fail. Remaining catches are Meta/GL/actor teardown guards. 2. All shell methods live in classes; no `this.` outside a class. 3. No `log()`. Debug output is `console.debug()` behind the `debug` setting. 4. `connectObject()` / `disconnectObject()` throughout; no raw connects in shell code. 5. Every source ID is tracked and removed in `destroy()`. 6. `PointerFocus.destroy()` calls `teardownPointerFocus()`. 7. `Gtk` / `Gdk` imports have no version pins. 8. No exported `_` functions. 9. `PlaidCore.destroy()` calls every subsystem; no selective destroy. 10. All cleanup is `destroy()`; `super.destroy()` is last. Also in this build: - Fixed lifecycle regressions in the BGAPP parking, dropdown terminal, and Flair across disable/lock cycles. Flair now reapplies immediately after unlock; no focus or mouse action is needed. - Fixed a workspace-switch recursion freeze with extensions that patch the switch animation. - Removed an obsolete Just Perfection workaround; Plaid no longer reads another extension's settings. - Made the `/proc` marker sweep fully asynchronous; no synchronous file IO remains in shell code. - Added a fast shell-shutdown teardown so logout no longer hits the 5s stop-sigterm timeout.