Review of "Colorful Battery Indicator" version 11

Details Page Preview

Make color of battery indicator change with level of battery charge

Extension Homepage
https://github.com/anerua/gnome-colorful-battery-indicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • __MACOSX/._metadata.json
    __MACOSX/._metadata.json
  • __MACOSX/._icons
    __MACOSX/._icons
  • __MACOSX/._extension.js
    __MACOSX/._extension.js
  • __MACOSX/icons/._battery-50-charging.svg
    __MACOSX/icons/._battery-50-charging.svg
  • __MACOSX/icons/._battery-50.svg
    __MACOSX/icons/._battery-50.svg
  • __MACOSX/icons/._battery-10-charging.svg
    __MACOSX/icons/._battery-10-charging.svg
  • __MACOSX/icons/._battery-10.svg
    __MACOSX/icons/._battery-10.svg
  • __MACOSX/icons/._battery-100-charging.svg
    __MACOSX/icons/._battery-100-charging.svg
  • __MACOSX/icons/._battery-100.svg
    __MACOSX/icons/._battery-100.svg
  • __MACOSX/icons/._battery-90-charging.svg
    __MACOSX/icons/._battery-90-charging.svg

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • __MACOSX/._extension.js

EGO-M-008 warning

extensions using unlock-dialog must document it in disable() comments

Extensions using `unlock-dialog` should document the reason in `disable()` comments.

Session Modes

  • extension.js:65
        disable() {
            this._getSystem((proxy, system) => {
                if (this._origSysIndicator) {
                    system.replace_child(
                        system._indicator,
                        this._origSysIndicator
                    );
                }
                if (this._powerProxyId) {
          

All Versions

Version Status
12 Active
11 Rejected
10 Active
9 Rejected
8 Active
7 Inactive
6 Rejected
5 Active
4 Inactive
3 Inactive
2 Inactive
1 Inactive

Previous Reviews on this Version

GdH rejected
Remove __MACOSX directory from the package.