Review of "Printers" version 34

Details Page Preview

Manage Jobs and Printers. Required package: cups-bsd

Extension Homepage
https://github.com/linux-man/gnome-shell-extension-printers

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:203
    sendJobs[sendJobs.length - 1].connect('activate', this.onSendToFrontClicked.bind(sendJobs[sendJobs.length - 1]))
  • extension.js:78
            this.menu.connect('open-state-changed', (self, open) => {
                this.menuIsOpen = open;
            })

All Versions

Previous Reviews on this Version

JustPerfection active