GNOME Shell Extensions

Review of "Printers" version 32

Details Page Preview

Printers

by linux-man

Manage Jobs and Printers. Required package: cups-bsd

Extension Homepage
https://github.com/linux-man/gnome-shell-extension-printers
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled 
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:69 
    this._settings.connect('changed', this.onCupsSignal.bind(this))
  • extension.js:183 
    sendJobs[sendJobs.length - 1].connect('activate', this.onSendToFrontClicked.bind(sendJobs[sendJobs.length - 1]))
  • extension.js:79 
            this.menu.connect('open-state-changed', (self, open) => {
            this.menuIsOpen = open;
        })

All Versions

Previous Reviews on this Version

fmuellner active