Review of "Smart Home" version 31

Details Page Preview

With this extension, you can control miscellaneous smart devices on your local network: * Home Assistant (lights, plugs, covers, scenes) * Philips Hue (Bridge, Syncbox, sync screen, sync music) * Nanoleaf devices (lights, scenes, sync screen) * Ikea Dirigera (lights, plugs, covers) * Shelly devices (lights, plugs, covers) * REST API available Please, report issues or bugs on GitHub.

Extension Homepage
https://github.com/vchlum/smart-home

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1 manual_review 1

Shexli found 2 issues that may need reviewer attention.

EGO-A-001 manual_review

extension code must not be minified or obfuscated

File appears obfuscated: 67% of identifiers are 1–2 characters (avg length 2.1).

Code must not be obfuscated

  • crypto/hashing.js
    short identifier ratio: 67%, identifiers scored: 148

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • crypto/hex.js

All Versions

Previous Reviews on this Version

JustPerfection waiting for author
Please give me the trace back for that timeout cleanup. Mainly I want to know where is the destroy function of that class?
chlumskyvaclav posted a review
Sure, the cleanup timeout traceback is here: smarthome-panelmenu.js:1251:cancelPendingRebuild(): GLib.Source.remove(this._rebuildTimer); smarthome-panelmenu.js:1473:disconnectSignals(): this.cancelPendingRebuild() smarthome.js:175:removePlugin(): this.instances[pluginID].disconnectSignals(); extension.js:179:disable(): this._smarthome.removePlugin(i)
JustPerfection active
Approved but please use a destroy function in `smarthome-panelmenu.js` so it is obvious that's the destroy function.
chlumskyvaclav posted a review
Thanks, the proper destroy fix is now in the repo. The next version will be fixed.