EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

• locale/switch-layout-tiling.pot

  locale/switch-layout-tiling.pot

• locale/ja/LC_MESSAGES/switch-layout-tiling.po

  locale/ja/LC_MESSAGES/switch-layout-tiling.po

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

• schemas/gschemas.compiled

  schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

• ui/editor/layoutMapEditor.js:51

      this._cancelButton = new St.Button({
        label: _('Cancel'),
        style_class: 'button',
      })

• ui/editor/layoutMapEditor.js:31

      this._container = new St.BoxLayout({
        style_class: 'layout-map-editor-action-buttons-pane',
        x_align: Clutter.ActorAlign.CENTER,
      })

• ui/editor/layoutMapEditor.js:45

      this._saveButton = new St.Button({
        label: _('Save'),
        style_class: 'button',
      })

• ui/indicatorMenu.js:288

  this._layoutMapListContainer = new St.BoxLayout({ vertical: true })

• ui/indicatorMenu.js:405

      this._clearButton = new St.Button({
        style_class: 'button',
        can_focus: true,
        track_hover: true,
        label: _('Clear All'),
      })

• ui/indicatorMenu.js:440

  this._container = new PopupMenu.PopupMenuSection()

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

• ui/editor/layoutMapEditor.js:51

      this._cancelButton = new St.Button({
        label: _('Cancel'),
        style_class: 'button',
      })

• ui/editor/layoutMapEditor.js:31

      this._container = new St.BoxLayout({
        style_class: 'layout-map-editor-action-buttons-pane',
        x_align: Clutter.ActorAlign.CENTER,
      })

• ui/editor/layoutMapEditor.js:45

      this._saveButton = new St.Button({
        label: _('Save'),
        style_class: 'button',
      })

• ui/indicatorMenu.js:288

  this._layoutMapListContainer = new St.BoxLayout({ vertical: true })

• ui/indicatorMenu.js:405

      this._clearButton = new St.Button({
        style_class: 'button',
        can_focus: true,
        track_hover: true,
        label: _('Clear All'),
      })

• ui/indicatorMenu.js:440

  this._container = new PopupMenu.PopupMenuSection()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• ui/editor/layoutMapEditor.js:55

  this._cancelButton.connect('clicked', this._handlers.onCancel)

• ui/editor/layoutMapEditor.js:49

  this._saveButton.connect('clicked', this._handlers.onSave)

• ui/indicatorMenu.js:414

      this._clearButton.connect('clicked', () => {
        this._handlers.onClearFixedAreas();
        this.refresh();
      })