Review of "Switch Layout Tiling" version 2

Details Page Preview

Tiles windows using user-defined layouts

Extension Homepage
https://github.com/shimamu/gnome-switch-layout-tiling

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • ui/editor/layoutMapEditor.js:65
        this._cancelButton = new St.Button({
          label: _('Cancel'),
          style_class: 'button',
        })
  • ui/editor/layoutMapEditor.js:31
        this._container = new St.BoxLayout({
          style_class: 'layout-map-editor-action-buttons-pane',
          x_align: Clutter.ActorAlign.CENTER,
        })
  • ui/editor/layoutMapEditor.js:59
        this._saveButton = new St.Button({
          label: _('Save'),
          style_class: 'button',
        })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • ui/editor/layoutMapEditor.js:69
    this._cancelButtonSignalId = this._cancelButton.connect('clicked', this._handlers.onCancel)
  • ui/editor/layoutMapEditor.js:63
    this._saveButtonSignalId = this._saveButton.connect('clicked', this._handlers.onSave)
  • ui/indicatorMenu.js:394
    signalId

All Versions

Version Status
2 Unreviewed
1 Rejected