Review of "Unity Buttons and Title" version 15

Details Page Preview

Unity-style close & restore buttons in the top panel with smart window centering. Features: • Unmaximized windows are centered and optionally resized • Original window size is remembered and restored • Live title tracking (Nautilus, browsers…) • XWayland support (Spotify, Electron apps) • Optional minimum open size for new windows • LibreOffice headerbar fix • Crash-safe button-layout backup/restore

Extension Homepage
https://github.com/Lokoyote/unity-buttons-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 2 warning 2

Shexli found 4 issues that may need reviewer attention.

EGO-C49-003 error

extensions targeting GNOME 49 must not call maximize or unmaximize with Meta.MaximizeFlags

This extension explicitly targets GNOME Shell 49 but still passes `Meta.MaximizeFlags` to `maximize()` or `unmaximize()`.

Meta.Window

  • extension.js:56
    w.maximize(Meta.MaximizeFlags.BOTH)
  • extension.js:60
    w.unmaximize(Meta.MaximizeFlags.BOTH)

EGO-C49-004 error

extensions targeting GNOME 49 must not call Meta.Window.get_maximized

This extension explicitly targets GNOME Shell 49 but still calls removed `Meta.Window.get_maximized()`.

Meta.Window

  • extension.js:50
    w.get_maximized()

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:212
            this._title = new St.Label({
                style_class: 'unity-title',
                y_align: Clutter.ActorAlign.CENTER,
            })
  • extension.js:201
            this.actor = new St.BoxLayout({
                style_class: 'unity-container',
                y_align: Clutter.ActorAlign.CENTER,
                visible: false,
            })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:212
            this._title = new St.Label({
                style_class: 'unity-title',
                y_align: Clutter.ActorAlign.CENTER,
            })
  • extension.js:201
            this.actor = new St.BoxLayout({
                style_class: 'unity-container',
                y_align: Clutter.ActorAlign.CENTER,
                visible: false,
            })

All Versions

Version Status
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Rejected
7 Rejected
6 Active
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

GdH active