Review of "Keyboard Modifiers Status" version 31

Details Page Preview

Shows keyboard modifiers status. It's useful when sticky keys are active.

Extension Homepage
https://github.com/sneetsher/Keyboard-Modifiers-Status

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 8 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:153
    console.warn(`${tag} No keyboard seat available; latch/lock updates will be unavailable`)
  • extension.js:223
    console.warn(`${tag} this._settings is null`)
  • extension.js:110
    console.error(`${tag} Failed to handle setting "${key}": ${e.message}`)
  • extension.js:137
    console.error(`${tag} Failed to acquire keyboard seat using all available APIs: ${fallbackError.message}`)
  • extension.js:148
    console.error(`${tag} Failed to connect keyboard accessibility modifier signal: ${e.message}`)
  • extension.js:240
    console.error(`${tag} Failed to load extension settings: ${e.message}`)
  • extension.js:312
    console.error(`${tag} Failed to register indicator in panel status area (${panelBox}, order ${this._indOrder}): ${e.message}`)
  • extension.js:372
    console.error(`${tag} Failed to add desktop overlay to Shell chrome: ${e.message}`)

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:99
    this._label = new St.Label({ style_class: 'state-label', text: this._indicatorText })
  • extension.js:344
            this._overlayLabel = new St.Label({
                style_class: 'kms-desktop-overlay-label',
                text: this._indicatorText,
            })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:350
            this._overlay.connect('button-press-event', (_actor, event) => {
                if (event.get_button() !== Clutter.BUTTON_PRIMARY)
                    return Clutter.EVENT_PROPAGATE;
    
                const [pointerX, pointerY] = global.get_pointer();
                this._overlayDragStart = {
                 

All Versions