Review of "Icon Matcher" version 12

Details Page Preview

Fixes broken app icons in the dock and overview.

Extension Homepage
https://github.com/PeppoDev/icon-matcher

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
13 Active
12 Rejected
11 Rejected
10 Active
9 Active
8 Active
7 Active
6 Rejected
5 Active
4 Rejected
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

Peppo posted a review
There are a lot of new files but it is basically the same as before divided into new specialist files instead of a one big file. There are no new features but there are a lot of improvements and bug fixes. This was necessary for new features in the future. I did a little patch notes with the changes: ## Bug fixes - Signal connections on windows were never cleaned up when a window closed before receiving a wm-class, leaking `Meta.Window` references indefinitely - Async IO writes (`replace_contents_bytes_async`) were not awaited — "fix written" was logged before the write finished, and errors were silently dropped - `Sync` was inserting `StartupWMClass` and `NoDisplay` at the end of the file, which placed them inside `[Desktop Action]` groups when the source had desktop actions, breaking the match and making the entry visible in the app grid - Ghost entries could be generated from other ghost entries - Heuristic scoring did not lowercase `wmClass` and `appId` before comparing, causing missed matches (Example: `TeamSpeak` → `com.teamspeak.TeamSpeak` scored 0, `Krita` → `org.kde.krita` missed entirely) - Blacklist patterns were not applied to wm classes shorter than 3 characters - Ghost entries whose source `.desktop` no longer exists are now deleted on sync - `DBusActivatable` is now stripped from ghost entries, preventing activation failures ## Improvements - `extension.ts` split extension god file into several specific files (`core`, `matching`, `entries`, `utils`) - Ghost entries now use `X-IconMatcher-*` keys instead of fragile header comments for metadata — enables reliable Sync and future reversibility - `MimeType` is stripped from ghost entries so they no longer appear as duplicates in "Open With" dialogs - Indexed app list speeding up matches - Blacklist compiled once speeding up matches (a little) - Unit tests (AI GENERATED) for easy new feature development (does not affect the built code, just saying for transparency) - Base ground for new features - Speed up icon detection - Re trigger indexer for all changes on desktop dir
Peppo posted a review
There are a lot of new files but it is basically the same as before divided into new specialist files instead of a one big file. There are no new features but there are a lot of improvements and bug fixes. This was necessary for new features in the future. I did a little patch notes with the changes: ## Bug fixes - Signal connections on windows were never cleaned up when a window closed before receiving a wm-class, leaking `Meta.Window` references indefinitely - Async IO writes (`replace_contents_bytes_async`) were not awaited — "fix written" was logged before the write finished, and errors were silently dropped - `Sync` was inserting `StartupWMClass` and `NoDisplay` at the end of the file, which placed them inside `[Desktop Action]` groups when the source had desktop actions, breaking the match and making the entry visible in the app grid - Ghost entries could be generated from other ghost entries - Heuristic scoring did not lowercase `wmClass` and `appId` before comparing, causing missed matches (Example: `TeamSpeak` → `com.teamspeak.TeamSpeak` scored 0, `Krita` → `org.kde.krita` missed entirely) - Blacklist patterns were not applied to wm classes shorter than 3 characters - Ghost entries whose source `.desktop` no longer exists are now deleted on sync - `DBusActivatable` is now stripped from ghost entries, preventing activation failures ## Improvements - `extension.ts` split extension god file into several specific files (`core`, `matching`, `entries`, `utils`) - Ghost entries now use `X-IconMatcher-*` keys instead of fragile header comments for metadata — enables reliable Sync and future reversibility - `MimeType` is stripped from ghost entries so they no longer appear as duplicates in "Open With" dialogs - Indexed app list speeding up matches - Blacklist compiled once speeding up matches (a little) - Unit tests (AI GENERATED) for easy new feature development (does not affect the built code, just saying for transparency) - Base ground for new features - Speed up icon detection - Re trigger indexer for all changes on desktop dir
Peppo posted a review
Duplicated message, bad internet connection.
JustPerfection rejected
This code seems to be generated by AI. Please note, we have a rule for that: - [EGO Review Guidelines: AI](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-must-not-be-ai-generated) - [Extensions Best Practices Guidelines](https://gjs.guide/extensions/review-guidelines/best-practices.html)
Peppo posted a review
The code is AI assisted, what mean that: all comments, all files, all features is hand written. The AI looked for bugs, help me understand what I can do to achieve what I want but even tough it generates something I simple rewritten it to fit more something that I should code. And you can simply look the old code and see that no feature was added and maybe notice that the same structure is there just improved or in some cases untouched.