Review of "Icon Matcher" version 3

Details Page Preview

Fixes broken app icons in the dock and overview.

Extension Homepage
https://github.com/PeppoDev/icon-matcher

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:402
    sourceFile.load_contents(null)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 20 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:49
    console.error("[IconMatcher] window disconnection failed", err)
  • extension.js:151
    console.error("[IconMatcher] _inspectWindow failed", err)
  • extension.js:396
    console.error("[IconMatcher] _applyPersistentFix failed", err)
  • extension.js:465
          console.error(
            "[IconMatcher] Could not launch update-desktop-database",
            err,
          )
  • extension.js:122
            console.log(
              "[IconMatcher] wm_class and app_id are the same, skipping to avoid potential mismatch",
              wmClass,
            )
  • extension.js:133
          console.log(
            `[IconMatcher] ✗ "${title}" is untracked (wm_class="${wmClass}", app_id="${appId}")`,
          )
  • extension.js:139
            console.log(
              `[IconMatcher] 	✔ Best candidate: ${candidate.get_id()} — applying fix`,
            )
  • extension.js:144
            console.log(
              `[IconMatcher] -> No candidate found, cannot fix automatically`,
            )
  • extension.js:214
          console.log(
            `[IconMatcher]   heuristic match (score=${bestScore}): ${bestApp.get_id()}`,
          )
  • extension.js:230
            console.log(
              `[IconMatcher] -> Skipping match for blacklisted prefix "${prefix}"`,
            )

All Versions

Version Status
9 Active
8 Active
7 Active
6 Rejected
5 Active
4 Rejected
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

Pepposo posted a review
That async write could not be a good practice but its whole solution
fmuellner active