Review of "Pulse Audio Shortcuts" version 8

Details Page Preview

Adds a PulseAudio shortcuts menu to the Volume Menu. GS >= 3.4 can manage the displayed shortcuts via the prefs tool. The shortcuts are displayed above Sound Settings, and also get added above various 'SoundMenu' extensions which force themselves to load at a desired position, we do no such forcing here. The 'PulseAudio' menu text can also be modified via the prefs tool. (Credit: lmedinas, Xes) This depends on the following, of which is your choice to use and install. To verify they are installed open a terminal and try to run any of the following: pavucontrol paprefs pavumeter pulseaudio-equalizer paman qpaeq gstreamer-properties

Extension Homepage
https://github.com/l300lvl/Pulse-Audio-Shortcuts

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
15 Active
14 Active
13 Active
12 Active
11 Rejected
10 Active
9 Rejected
8 Rejected
7 Rejected
6 Rejected
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

l300lvl posted a review
I believe I worked everything out with this one, that I can see. Please look over disable though, I don't want to do anything bad there.
Jasper St. Pierre posted a review
First, you seem to be mixing tabs and spaces or something because your indentation is all out of whack. Second, you seem to be doing things like 'if (foo == true)'. 'if (foo)' should be enough. In the case of 'if (foo == false)', use 'if (!foo)' instead. Your localization strategy is bad. You can't assume you can concatenate user-provided strings like that and have localized things. You also try to use the Shell's localization, which won't work. I don't see why you assign variables to constants, and then not modify them. Just the constants should be fine. Why are you checking the constants instead of the objects when you try to disable them? Have you considered using "else" more? You're also assigning to "this._appMenu". Because this is a global function, you're assigning to the global object. Yay.