Review of "Pulse Audio Shortcuts" version 12

Details Page Preview

Adds a PulseAudio shortcuts menu to the Volume Menu. GS >= 3.4 can manage the displayed shortcuts via the prefs tool. The shortcuts are displayed above Sound Settings, and also get added above various 'SoundMenu' extensions which force themselves to load at a desired position, we do no such forcing here. The 'PulseAudio' menu text can also be modified via the prefs tool. (Credit: lmedinas, Xes) This depends on the following, of which is your choice to use and install. To verify they are installed open a terminal and try to run any of the following: pavucontrol paprefs pavumeter pulseaudio-equalizer paman qpaeq gstreamer-properties

Extension Homepage
https://github.com/l300lvl/Pulse-Audio-Shortcuts

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
15 Active
14 Active
13 Active
12 Active
11 Rejected
10 Active
9 Rejected
8 Rejected
7 Rejected
6 Rejected
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

l300lvl posted a review
I wasn't sure you could do the braces inside of an else statement. Why would it still try to create something that should be spawned only if fi = true or 1
Jasper St. Pierre posted a review
Everywhere you need more than one line in an if statement, you need braces. Anyway, the indentation is still messed up, but sure.
l300lvl posted a review
Please enlighten on the indentation. Is the problem something like, for instance, the following: } else { if (SEPERATOR) itemSeparator.destroy(); Should this be: } else { if (SEPERATOR) itemSeparator.destroy(); Meaning it would be 4 spaces everywhere? If that isn't it I must be blind because it's the only place I see more than four spaces.
Jasper St. Pierre posted a review
I was referring to: } else { pulseMenu = Main.panel._statusArea.volume; nItems = pulseMenu.menu.numMenuItems; if (SEPERATOR) { itemSeparator = new PopupMenu.PopupSeparatorMenuItem(); pulseMenu.menu.addMenuItem(itemSeparator, nItems - 3); } } That's what it should be. Of course, the else block in disable should be indented as well.