Review of "Pulse Audio Shortcuts" version 10

Details Page Preview

Adds a PulseAudio shortcuts menu to the Volume Menu. GS >= 3.4 can manage the displayed shortcuts via the prefs tool. The shortcuts are displayed above Sound Settings, and also get added above various 'SoundMenu' extensions which force themselves to load at a desired position, we do no such forcing here. The 'PulseAudio' menu text can also be modified via the prefs tool. (Credit: lmedinas, Xes) This depends on the following, of which is your choice to use and install. To verify they are installed open a terminal and try to run any of the following: pavucontrol paprefs pavumeter pulseaudio-equalizer paman qpaeq gstreamer-properties

Extension Homepage
https://github.com/l300lvl/Pulse-Audio-Shortcuts

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
15 Active
14 Active
13 Active
12 Active
11 Rejected
10 Active
9 Rejected
8 Rejected
7 Rejected
6 Rejected
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

Jasper St. Pierre posted a review
You didn't fix all the indentation, just some of it. Nevertheless, this looks good enough.
l300lvl posted a review
Would that mean: let app = Util.spawn([CUSTOM_COMMAND]); app.activate(); Probably needs fixed? It would make sense to me, but I am curious. I was also wondering what the terminology might be for the different indentations, if any, is there any reading you might suggest? -Gratz.
Jasper St. Pierre posted a review
No. I'm talking about the code in enable and disable. The code in _onCustomApp seems to be fine.