Review "Input Method Panel" version 6 - GNOME Shell Extensions

Review of "Input Method Panel" version 6

Details Page Preview

Input Method Panel

by csslayer

Input Method Panel using KDE's kimpanel protocol for Gnome-Shell

Extension Homepage: https://github.com/wengxt/gnome-shell-extension-kimpanel

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
80	Active
79	Active
78	Active
77	Active
76	Active
75	Active
74	Rejected
73	Active
72	Active
71	Active
70	Active
69	Active
68	Active
67	Active
66	Rejected
65	Active
64	Active
63	Active
62	Active
61	Active
60	Active
59	Active
58	Active
57	Active
56	Active
55	Active
54	Active
53	Active
52	Active
51	Active
50	Rejected
49	Active
48	Inactive
47	Inactive
46	Rejected
45	Active
44	Rejected
43	Active
42	Inactive
41	Rejected
40	Inactive
39	Active
38	Active
37	Active
36	Active
35	Active
34	Active
33	Active
32	Active
31	Active
30	Active
29	Active
28	Active
27	Active
26	Rejected
25	Active
24	Active
23	Rejected
22	Active
21	Active
20	Active
19	Inactive
18	Active
17	Rejected
16	Active
15	Rejected
14	Rejected
13	Active
12	Rejected
11	Rejected
10	Rejected
9	Rejected
8	Active
7	Active
6	Inactive
5	Inactive
4	Active
3	Rejected
2	Rejected
1	Rejected

Previous Reviews on this Version

gcampax posted a review April 30, 2012

You're using dbus-glib from import.dbus and GDBus from imports.gi.Gio. Strange it didn't break yet. But changes in this revision seem ok, so approving.

csslayer posted a review May 1, 2012

I'm sorry... but, imports.DBus I think it's not dbus-glib. It's the "convenient" binding in gjs.

gcampax posted a review May 1, 2012

No, it is the old "convenient" binding, implemented using libdbus / dbus-glib. The new one lives directly in imports.gi.Gio, in the form of Gio.DBusProxy.makeProxyWrapper and Gio.DBusExportedObject.wrapJSObject (see examples in the shell for usage).